Deprecate some non-standard and obsolete types and fields. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should deprecate the type aliases instead of disabling fatal warnings. |
danielnixon
force-pushed
the
deprecations
branch
from
3ad4406 to
c5b8b02
Compare
|
Done (and squashed). |
|
The first two commits should be squashed together, because the first one doesn't build on its own. The commit message of the third commit doesn't make sense to me wrt. the contents of the commit. Maybe it's better to just squash everything together, here, as everything is about deprecations anyway. |
See: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/bgsound * https://msdn.microsoft.com/en-us/library/windows/apps/hh965347.aspx * https://developer.mozilla.org/en-US/docs/Web/API/window/setImmediate * https://developer.mozilla.org/en-US/docs/Web/API/Window/clearImmediate * https://developer.mozilla.org/en/docs/Web/API/Event/srcElement * https://msdn.microsoft.com/en-us/library/hh869721(v=vs.85).aspx * https://www.w3.org/TR/html5/obsolete.html * https://developer.mozilla.org/en-US/docs/Web/API/HTMLFontElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLBaseFontElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHeadElement * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dir * https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent/initAnimationEvent * https://developer.mozilla.org/en-US/docs/Web/API/HTMLFrameSetElement * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frame * https://developer.mozilla.org/en/docs/Web/API/HTMLTableCellElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableRowElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableColElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLDivElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHRElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHeadingElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLParagraphElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableCaptionElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement * https://developer.mozilla.org/en-US/docs/Web/API/Document/applets * https://developer.mozilla.org/en-US/docs/Web/API/HTMLAreaElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement * https://msdn.microsoft.com/en-us/library/ff521069(v=vs.85).aspx * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableSectionElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLParamElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLPreElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLBRElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement * https://dom.spec.whatwg.org/#dom-traversal-changes * https://dom.spec.whatwg.org/#nodeiterator * https://dom.spec.whatwg.org/#treewalker * https://dom.spec.whatwg.org/#htmlcollection
danielnixon
force-pushed
the
deprecations
branch
from
a363b4a to
b35b6e7
Compare
|
I think the build failure was because Travis couldn't resolve some dependencies. Everything squashed. Thanks @sjrd ! |
sjrd
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to turn off fatal warnings because the type aliases refer to the deprecated types. It might be better to remove the type aliases entirely, or even skip deprecation and just remove the offending types and fields immediately.
See: